Poster board step 2 test PR#5544
Conversation
Verbatim copy of the boxel-catalog poster-board (steps 1+2: pan/zoom rig, PosterBoard card def with linked-card tiles, live tests, demo instance). Canonical home is the catalog repo (boxel-catalog#666, #667); this copy exists so monorepo review tooling can see it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19aba32268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.panSession = this.surfaceRig.startPan(event.clientX, event.clientY); | ||
| this.isPanning = true; | ||
| (event.currentTarget as HTMLElement).setPointerCapture(event.pointerId); | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Avoid starting board pans from card tiles
When the pointer starts inside a rendered card tile, this handler still starts a board pan because only the HUD is exempted. On boards whose fitted cards contain controls, selectable text, or their own drag/focus behavior, the root captures the pointer and prevents the child's normal pointer/focus interaction; the pan should ignore tile/interactive descendants or wait until movement crosses a drag threshold.
Useful? React with 👍 / 👎.
| {{#let (get @fields.cards tile.index) as |LinkedCard|}} | ||
| <LinkedCard @format='fitted' /> |
There was a problem hiding this comment.
Render broken-link placeholders in placed tiles
When a board link resolves to not-found or error (including the demo links when this copy runs in the experiments realm), this direct indexed render bypasses the linksToMany renderer's broken-slot branch and invokes a normal card component with an undefined model, producing a blank fitted tile instead of the standard broken-link placeholder/open affordance. Custom placement needs to render the broken state for that slot rather than only the child component.
Useful? React with 👍 / 👎.
Test PR for review feedback on the poster-board (steps 1+2) — a verbatim copy of the boxel-catalog
poster-board/placed in the experiments realm so monorepo review tooling can see it. Not intended to merge; the canonical PRs are cardstack/boxel-catalog#666 (pan/zoom board) and cardstack/boxel-catalog#667 (linked-card tiles).Contents:
rig.gts(camera engine with momentum),poster-board.gts(PosterBoard card def: pan/zoom surface + fitted card tiles placed byframeSettingsor a default grid), live tests (5 tests / 13 assertions, passing against the catalog realm), README, and the demo instance. Note the demo instance'scardslinks point at catalog-realm paths, so they resolve as broken links inside the experiments realm — expected for this copy.🤖 Generated with Claude Code