Skip to content

Poster board step 2 test PR#5544

Open
burieberry wants to merge 1 commit into
mainfrom
poster-board-step-2-test-pr
Open

Poster board step 2 test PR#5544
burieberry wants to merge 1 commit into
mainfrom
poster-board-step-2-test-pr

Conversation

@burieberry

Copy link
Copy Markdown
Contributor

Test PR for review feedback on the poster-board (steps 1+2) — a verbatim copy of the boxel-catalog poster-board/ placed in the experiments realm so monorepo review tooling can see it. Not intended to merge; the canonical PRs are cardstack/boxel-catalog#666 (pan/zoom board) and cardstack/boxel-catalog#667 (linked-card tiles).

Contents: rig.gts (camera engine with momentum), poster-board.gts (PosterBoard card def: pan/zoom surface + fitted card tiles placed by frameSettings or a default grid), live tests (5 tests / 13 assertions, passing against the catalog realm), README, and the demo instance. Note the demo instance's cards links point at catalog-realm paths, so they resolve as broken links inside the experiments realm — expected for this copy.

🤖 Generated with Claude Code

Verbatim copy of the boxel-catalog poster-board (steps 1+2: pan/zoom rig,
PosterBoard card def with linked-card tiles, live tests, demo instance).
Canonical home is the catalog repo (boxel-catalog#666, #667); this copy
exists so monorepo review tooling can see it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19aba32268

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +132 to +135
this.panSession = this.surfaceRig.startPan(event.clientX, event.clientY);
this.isPanning = true;
(event.currentTarget as HTMLElement).setPointerCapture(event.pointerId);
event.preventDefault();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid starting board pans from card tiles

When the pointer starts inside a rendered card tile, this handler still starts a board pan because only the HUD is exempted. On boards whose fitted cards contain controls, selectable text, or their own drag/focus behavior, the root captures the pointer and prevents the child's normal pointer/focus interaction; the pan should ignore tile/interactive descendants or wait until movement crosses a drag threshold.

Useful? React with 👍 / 👎.

Comment on lines +241 to +242
{{#let (get @fields.cards tile.index) as |LinkedCard|}}
<LinkedCard @format='fitted' />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render broken-link placeholders in placed tiles

When a board link resolves to not-found or error (including the demo links when this copy runs in the experiments realm), this direct indexed render bypasses the linksToMany renderer's broken-slot branch and invokes a normal card component with an undefined model, producing a blank fitted tile instead of the standard broken-link placeholder/open affordance. Custom placement needs to render the broken state for that slot rather than only the child component.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant